Skip to content

ci: cleanup pipeline.yml #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2021
Merged

ci: cleanup pipeline.yml #326

merged 1 commit into from
Apr 12, 2021

Conversation

MichaelDeBoey
Copy link
Member

No description provided.

Belco90
Belco90 requested changes Apr 12, 2021
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give some context please?

@MichaelDeBoey
Copy link
Member Author

@Belco90 access_token isn't required anymore by styfle/cancel-workflow-action (see https://github.com/styfle/cancel-workflow-action/releases/tag/0.7.0 & https://github.com/styfle/cancel-workflow-action/blob/c7e080941fa9ad564b8f5277ba3b55a3cfbed06f/action.yml#L15-L17)

@Belco90
Copy link
Member

Belco90 commented Apr 12, 2021

I see. It's weird they still refer to that property as required in the main usage section of the README.

@Belco90 Belco90 changed the title chore: cleanup pipeline.yml ci: cleanup pipeline.yml Apr 12, 2021
@Belco90 Belco90 merged commit 2a92133 into testing-library:main Apr 12, 2021
@MichaelDeBoey MichaelDeBoey deleted the patch-1 branch April 12, 2021 10:24
@github-actions
Copy link

🎉 This PR is included in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @Belco90