chore: Don't test with node 10 #395
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's best to wait until ESlint drops support for older versions before we do too Ref: eslint/eslint#14023 |
|
It seems like ESLint 8 has dropped it as of August 5th. |
|
Does merging this depend on #462? |
That's right. We can point this MR to the alpha branch for the next major, right? @MichaelDeBoey |
|
Going to close this one as #463 already took care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Don't test with node 10
Why: Node 10 reached EOL on July 30th so let's free up some CI resources.
How: Remove 10 from node test matrix.
Checklist:
[ ]Documentation added to thedocs site
[ ]Typescript definitions updated