Skip to content

chore: add editorconfig file #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Oct 8, 2024

Checks

Changes

  • Adds a .editorconfig file to tell tools that tabs should be used instead of spaces, along with a few other config options

Context

Most editors these days understand .editorconfig out of the box, and in particular this will help ensure that tabs are used by default over spaces when writing code including in situations that Prettier won't catch such as in string literals

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (93a6ab9) to head (393d5a8).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
+ Coverage   96.23%   96.32%   +0.08%     
==========================================
  Files          44       44              
  Lines        2419     2449      +30     
  Branches     1000     1023      +23     
==========================================
+ Hits         2328     2359      +31     
+ Misses         91       90       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have Prettier installed, so I'd rather have people use their IDE's on save functionality tbh

@G-Rath
Copy link
Contributor Author

G-Rath commented Oct 16, 2024

As I said in the context section, Prettier doesn't help here because it doesn't apply in string literals - this isn't about automatic formatting, but what IDEs use for indentation by default i.e. when you start a newline from an already intended line, editors typically keep you on the same level of indenting, which they do by inserting either spaces or tabs

@MichaelDeBoey MichaelDeBoey requested a review from Belco90 October 17, 2024 00:43
@MichaelDeBoey MichaelDeBoey added the chore Changes that affect the build system, CI config or other changes that don't modify src/test files label Oct 17, 2024
@Belco90 Belco90 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into testing-library:main with commit d9bcc07 Oct 17, 2024
31 checks passed
@Belco90
Copy link
Member

Belco90 commented Oct 17, 2024

@all-contributors please add @G-Rath for code, maintenance

Copy link
Contributor

@Belco90

I've put up a pull request to add @G-Rath! 🎉

Copy link

🎉 This PR is included in version 6.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@G-Rath G-Rath deleted the add-editor-config branch October 17, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that affect the build system, CI config or other changes that don't modify src/test files hacktoberfest-accepted released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants