-
Notifications
You must be signed in to change notification settings - Fork 150
chore: add editorconfig file #935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
==========================================
+ Coverage 96.23% 96.32% +0.08%
==========================================
Files 44 44
Lines 2419 2449 +30
Branches 1000 1023 +23
==========================================
+ Hits 2328 2359 +31
+ Misses 91 90 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have Prettier installed, so I'd rather have people use their IDE's on save functionality tbh
As I said in the context section, Prettier doesn't help here because it doesn't apply in string literals - this isn't about automatic formatting, but what IDEs use for indentation by default i.e. when you start a newline from an already intended line, editors typically keep you on the same level of indenting, which they do by inserting either spaces or tabs |
@all-contributors please add @G-Rath for code, maintenance |
I've put up a pull request to add @G-Rath! 🎉 |
🎉 This PR is included in version 6.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Checks
Changes
.editorconfig
file to tell tools that tabs should be used instead of spaces, along with a few other config optionsContext
Most editors these days understand
.editorconfig
out of the box, and in particular this will help ensure that tabs are used by default over spaces when writing code including in situations that Prettier won't catch such as in string literals