Skip to content

feat(no-wait-for-empty-callback ): new rule no-wait-for-empty-callback #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2020
Merged

feat(no-wait-for-empty-callback ): new rule no-wait-for-empty-callback #94

merged 2 commits into from
Mar 21, 2020

Conversation

timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Mar 20, 2020 •
edited
Loading

Closes #92

This rule covers:

  • empty arrow function (i.e. () => {})
  • empty regular function (i.e. function () {})
  • a function or var called noop

Inspired by eslint no-empty-function rule

@timdeschryver timdeschryver added the new rule New rule to be included in the plugin label Mar 20, 2020
@timdeschryver
Copy link
Member Author

@Belco90 this is what we're aiming for, right?
Not sure how we can tackle a var referencing any of previously mentioned

@Belco90
Copy link
Member

Belco90 commented Mar 20, 2020

Yes! This is exactly what we need. Let's leave the var referencing for future improvement if necessary. I'll add couple of comments tho I know this is just a draft.

Belco90
Belco90 reviewed Mar 20, 2020
View reviewed changes
@timdeschryver timdeschryver changed the title feat: add no-wait-for-empty-callback rule feat(no-wait-for-empty-callback ): new rule no-wait-for-empty-callback Mar 21, 2020
@timdeschryver timdeschryver marked this pull request as ready for review March 21, 2020 12:46
@Belco90 Belco90 changed the base branch from master to v3 March 21, 2020 17:33
Belco90
Belco90 approved these changes Mar 21, 2020
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@Belco90 Belco90 merged commit e50546d into v3 Mar 21, 2020
@Belco90 Belco90 deleted the pr/no-wait-for-empty-callback branch March 21, 2020 18:23
Belco90 added a commit that referenced this pull request Mar 29, 2020
@Belco90 @timdeschryver
feat: plugin v3 (#97)
8c2dc0c 
feat(await-async-utils): reflect waitFor changes (#89)
feat: new rule no-wait-for-empty-callback (#94)
feat: new rule prefer-wait-for (#88)
feat: new rule prefer-screen-queries (#99)
BREAKING CHANGE: drop support for node v8. Min version allowed is node v10.12 (#96)
BREAKING CHANGE: rule `no-get-by-for-checking-element-not-present` removed in favor of new rule `prefer-presence-queries` (#98)

Closes #85
Closes #86
Closes #90
Closes #92
Closes #95

Co-authored-by: timdeschryver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees
No one assigned
Labels
new rule New rule to be included in the plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New rule: no-wait-for-empty-cb
2 participants
@timdeschryver @Belco90