fix(jest-dom): Update deprecated messaging for toHaveDescription to p… #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovide advice on using toHaveAccessibleDescription instead
gnapse
approved these changes
Aug 3, 2021
Codecov Report
@@ Coverage Diff @@
## main #390 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 615 615
Branches 223 225 +2
=========================================
Hits 615 615
Continue to review full report at Codecov.
|
|
No point fixing the conflicts since another PR has been raised and merged since: #422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Update deprecated messaging for toHaveDescription to provide advice on using toHaveAccessibleDescription instead
Why:
The deprecation message for
toHaveDescriptionwas wrong, I assume because of a copy/paste mishap.This updates it to be more helpful in migrating away from the deprecated function.
How:
By modifying the deprecated messaging for
toHaveDescription.Checklist: