This repository was archived by the owner on Jul 30, 2020. It is now read-only.
Fix TypeScript return types for query methods #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 20
Lines 262 262
Branches 65 65
=====================================
Hits 262 262Continue to review full report at Codecov.
|
|
Thanks for this! @all-contributors[bot] please add @lewie9021 for code. |
|
I've put up a pull request to add @lewie9021! 🎉 |
bcarroll22
approved these changes
May 21, 2019
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Modified return types for all query methods (e.g. getByTestId) from
ReactTestRenderertoNativeTestInstance.Why:
As noted in #20, for projects using TypeScript, it is confusing to see false type errors within tests when firing events and accessing element props.
How:
Simply modified the type definitions directly. I'm assuming this project is written with normal JavaScript and therefore TypeScript definitions are manually maintained?
Checklist:
docs site (N/A)