-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
BREAKING CHANGEThis change will require a major version bumpThis change will require a major version bumpreleased
Metadata
Metadata
Assignees
Labels
BREAKING CHANGEThis change will require a major version bumpThis change will require a major version bumpreleased
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
donavon commentedon Feb 16, 2019
I'm all for this
https://twitter.com/donavon/status/1096061809499561984
react-hooks-testing-library
?kentcdodds commentedon Feb 16, 2019
You make it, and I'll make this happen
ooade commentedon Feb 16, 2019
Yeah 🤸
donavon commentedon Feb 16, 2019
I have some family obligations today, but will get on this as soon as I can. But go out and grab the npm name
donavon commentedon Feb 16, 2019
Um... https://www.npmjs.com/package/react-hooks-testing-library
kentcdodds commentedon Feb 16, 2019
Oh cool! Could you give it a look and open an issue for anything that's lacking/different and see if the maintainer is interested in doing/accepting what we need?
alexkrolick commentedon Feb 16, 2019
Well, we also pulled a Webpack and released with no docs. I think this is pretty prominently explained in the docs PR for testHook: testing-library/testing-library-docs#32
The linked package seems pretty close in API - I'll file an issue since you both are indisposed.
mpeyper commentedon Feb 17, 2019
Hey, author of
react-hooks-testing-library
here.I started out with a "what would
react-testing-library
do" mentality so I'm not surprised that API is pretty close.As I said in the other issue, it started out as a proof-of-concept from my perspective and I only updated it recently to match the stable hooks API in case anyone was actually using it. I've had a few thoughts on how the API could be improved, but nothing nailed down. I'm more than happy to accept PRs bringing it inline with any features offered by
testHook
(at a quick glance it's pretty much on par), or even for large breaking changes.mpeyper commentedon Feb 21, 2019
Just wanted to let you all know that I have published a
testHook
compatible version of react-hooks-testing-library (v0.3.2 is the current version in NPM).kentcdodds commentedon Feb 24, 2019
Awesome. I think we're ready to make this happen. Anyone want to make the PR too remove testHook?
schettino commentedon Feb 24, 2019
I can handle this. :)
26 remaining items