Skip to content

Conversation

eventualbuddha
Copy link
Contributor

What: This is a bug fix to ensure proxied console.error calls are passed through correctly.

Why: Without them, console.log('Value:', 1) would get logged as ['Value:', 1] instead of Value: 1.

How: I'm not sure how this applies.

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests N/A
  • Typescript definitions updated N/A
  • Ready to be merged

eventualbuddha and others added 2 commits August 16, 2019 13:57
Without this the proxied errors are logged as an array, which is not very helpful.
kentcdodds
kentcdodds previously approved these changes Aug 16, 2019
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting us know about this problem!

@kentcdodds kentcdodds merged commit f4f3ea5 into testing-library:master Aug 16, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @eventualbuddha for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @eventualbuddha! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 9.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants