Skip to content

fix: spread console error args when proxying #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2019
Merged

fix: spread console error args when proxying #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcc5b0a
fix: spread console error args when proxying
eventualbuddha Aug 16, 2019
f7b8e5d
Update act-compat.js
Aug 16, 2019
366c177
Update old-act.js
Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/__tests__/old-act.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ test('async act works even when the act is an old one', async () => {
expect(console.error.mock.calls).toMatchInlineSnapshot(`
Array [
Array [
Array [
"sigil",
],
"sigil",
],
Array [
"It looks like you're using a version of react-dom that supports the \\"act\\" function, but not an awaitable version of \\"act\\" which you will need. Please upgrade to at least [email protected] to remove this warning.",
Expand Down
2 changes: 1 addition & 1 deletion src/act-compat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function asyncAct(cb) {
) {
// no-op
} else {
originalConsoleError.call(console, args)
originalConsoleError.apply(console, args)
}
}
let cbReturn, result
Expand Down