Skip to content

Dependancy on @testing-library/dom at ^7.0.2 causes failed installs on node less than 10.18 #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SamTolmay opened this issue Mar 18, 2020 · 1 comment · Fixed by #617
Labels

Comments

@SamTolmay
Copy link

  • @testing-library/react version: 10.0.1
  • react version: 16.13.0
  • node version: 10.16.3
  • npm (or yarn) version: yarn v1.17.3

Relevant code or config:

"@testing-library/dom@^7.0.2":
  version "7.0.2"
  resolved "https://registry.yarnpkg.com/@testing-library/dom/-/dom-7.0.2.tgz#9edc922dfe2644a3f0ff70f256d8c78a525b88c3"
  integrity sha512-5pqMlPaBC/5bvvFtuNTTcB4/Vg8NjZfs11LQQc08JhpMfx82W85nVw3re4D92A/C5O8zDkxPxyYPWNp8PtnQ/w==
  dependencies:
    "@babel/runtime" "^7.8.4"
    "@types/testing-library__dom" "^6.12.1"
    aria-query "^4.0.2"
    dom-accessibility-api "^0.3.0"
    pretty-format "^25.1.0"

"@testing-library/[email protected]":
  version "10.0.1"
  resolved "https://registry.yarnpkg.com/@testing-library/react/-/react-10.0.1.tgz#4f5e2a8836257c5bd3df640b21d7bea5a0d83ead"
  integrity sha512-sMHWud2dcymOzq2AhEniICSijEwKeTiBX+K0y36FYNY7wH2t0SIP1o732Bf5dDY0jYoMC2hj2UJSVpZC/rDsWg==
  dependencies:
    "@babel/runtime" "^7.8.7"
    "@testing-library/dom" "^7.0.2"
    "@types/testing-library__react" "^9.1.3"

What you did:

What happened:

Error message:

error @testing-library/[email protected]: The engine "node" is incompatible with this module. Expected version ">=10.18". Got "10.16.3"

Reproduction:

Problem description:

Yarn install is failing on node versions less the 10.18. This was fixed in @testing-library/react in version 10.0.1, and in @testing-library/dom in version 7.0.3. However, @testing-library/react requires @testing-library/dom at version ^7.0.2. Thus if @testing-library/dom is pinned at v7.0.2 in yarn.lock, yarn install still fails for node less than version 10.18.

This is an issue since AWS CodeBuild still runs on node v10.16

Suggested solution:

Require @testing-library/dom at version 7.0.3 or higher.

@kentcdodds
Copy link
Member

🎉 This issue has been resolved in version 10.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants