Skip to content

fix: bump minimal /dom version #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2020
Merged

fix: bump minimal /dom version #617

merged 1 commit into from
Mar 18, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Mar 18, 2020

What:

Closes #616

Why:

Propagates downstream fix faster.

How:

Bump minimal required version from 7.0.2 to 7.0.3

Checklist:

  • [ ] Documentation added to the
    docs site
  • [ ] Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

@eps1lon eps1lon added the bug Something isn't working label Mar 18, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9ac91e2:

Sandbox Source
magical-stallman-9zv67 Configuration
react-testing-library demo Issue #616

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #617 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #617   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          103       103           
  Branches        15        15           
=========================================
  Hits           103       103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc13d9...9ac91e2. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@kentcdodds kentcdodds merged commit 77186fe into master Mar 18, 2020
@eps1lon eps1lon deleted the eps1lon-patch-1 branch March 18, 2020 12:20
@kentcdodds
Copy link
Member

🎉 This PR is included in version 10.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependancy on @testing-library/dom at ^7.0.2 causes failed installs on node less than 10.18
2 participants