update typings with dom-testing-library queries and export them #130
Conversation
kentcdodds
added
the
TypeScript
There was a problem hiding this comment.
It's hard to parse the diff because so many lines were moved around. It's hard to tell what's new vs what was just moved. Also, I didn't think all those newly exported functions are actually exported from react-testing-library. I just thought they were part of the RenderResult type, which was already defined that way.
Can you provide some more context as to why these changes are being made?
|
@pbomb I changed the order to match with the order here: https://github.com/kentcdodds/dom-testing-library/blob/master/typings/queries.d.ts and they are exported because this functions can also be imported from 'react-testing-library' |
|
Okay, making the orders consistent seems reasonable to do. 👍 I still didn't think the dom-testing-library functions were re-exported from react-testing-library. Where do you see that in the code? @kentcdodds can you confirm if the dom-testing-library query functions are re-exported from react-testing-library? |
|
ah, nice! I totally missed that when I read the file the first time. This PR looks good to me! |
|
Thanks @jpavon! |
|
🎉 This PR is included in version 4.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@pbomb @kentcdodds I'm thinking having |
|
Sounds good to me |
…g-library#130) **What**: Added attribute argument to type `QueryByAttribute` and `AllByAttribute` **Why**: This argument seems to be falsely missing. Usage of `AllByAttribute` can bee seen here: https://github.com/BenjaminEckardt/dom-testing-library/blob/master/src/queries.js#L60 Usage of `QueryByAttribute` is a bit less obvious due to currying but can be seen here: https://github.com/kentcdodds/dom-testing-library/blob/master/src/queries.js#L153 **How**: Just added the missing attribute. **Checklist**: - [ ] Documentation N/A - [x] Tests - [x] Ready to be merged - [x] Added myself to contributors table
…ltiple Select multiple
What: Update queries typings to match dom-testing-library
Why: Not up to date typings with dom-testing-library
How: Modify typings/index.d.ts.
Checklist: