feat(render): add new query capabilities for improved tests #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
force-pushed
the
pr/improved-utilities
branch
from
6bed73e to
74ecfa6
Compare
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 2 +1
Lines 10 53 +43
Branches 1 13 +12
=====================================
+ Hits 10 53 +43
Continue to review full report at Codecov.
|
kentcdodds
force-pushed
the
pr/improved-utilities
branch
from
74ecfa6 to
c53b317
Compare
**What**: Add the following methods - queryByText - getByText - queryByPlaceholderText - getByPlaceholderText - queryByLabelText - getByLabelText **Why**: Closes #16 These will really improve the usability of this module. These also align much better with the guiding principles 👍 **How**: - Created a `queries.js` file where we have all the logic for the queries and their associated getter functions - Migrate tests where it makes sense - Update docs considerably. **Checklist**: * [x] Documentation * [x] Tests * [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? --> * [ ] Added myself to contributors table N/A
kentcdodds
force-pushed
the
pr/improved-utilities
branch
from
c53b317 to
8fa8cc5
Compare
|
I'm really excited about this!! |
julienw
pushed a commit
to julienw/react-testing-library
that referenced
this pull request
Dec 20, 2018
…his API (testing-library#18) * Add bindQueriesToElement utility function for libraries using this API * Add documentation and update contributors * Rename to bindElementToQueries as this seems to be more appropriate Closes testing-library#17
lucbpz
pushed a commit
to lucbpz/react-testing-library
that referenced
this pull request
Jul 26, 2020
fix: 🐛 click() handles checkboxes correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Add the following methods
Why: Closes #16
These will really improve the usability of this module. These also align much better with the guiding principles 👍
How:
queries.jsfile where we have all the logic for the queries and their associated getter functionsChecklist: