-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Debug helper on get
calls.
#41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kentcdodds Hey Kent.. I have just initiated the thread for printing the DOM element when Looks cool to me and definitely its going to help in debugging the process as discussed. Things that are pending:
I guess that should be fine, let me know what you feel. Note: The sample test case will be failing, anyways will fix once we are good to merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Yes, let's move forward with your plan. I like the environment variable idea. Thanks!
Cool! Will get back on this by weekend. |
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 98 115 +17
Branches 22 25 +3
=====================================
+ Hits 98 115 +17
Continue to review full report at Codecov.
|
@kentcdodds Updated the codebase, let me know if anything else is pending. |
Could we move this over to dom-testing-library? Sorry to change things underneath you! |
What: This is already discussed here : #31
Why: Again discussed here : #31
How:
Checklist: