README: update @testing-library/jest-dom's old syntax #590
Conversation
[@testing-library/jest-dom v5.0.0](https://github.com/testing-library/jest-dom/releases/tag/v5.0.0) later, import statement had BreakingChange. So update to latest that in the README example. Thank you 😀
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a5940dd:
|
Codecov Report
@@ Coverage Diff @@
## master #590 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 95 103 +8
Branches 15 15
=====================================
+ Hits 95 103 +8
Continue to review full report at Codecov.
|
|
@gnapse Could you review? I don't see this breaking change mentioned in the breaking changes. |
There was a problem hiding this comment.
To be clear, in the update to v5 there are breaking changes, but this is not a part of it. You can continue importing from @testing-library/jest-dom/extend-expect even though we started providing the import from the main entry module @testing-library/jest-dom.
However, this change proposal seems good anyway, given that this is the new recommended way to import now.
|
@all-contributors please add @ryota-murakami for docs |
|
I've put up a pull request to add @ryota-murakami! 🎉 |
|
@ryota-murakami Much appreciated, thanks! |
|
🎉 This PR is included in version 9.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
Update
@testing-library/jest-domimport statement to latest syntax in the README example.Why:
@testing-library/jest-dom v5.0.0 later, import statement had BreakingChange.
How:
Edit README.md
import '@testing-library/jest-dom/extend-expect'toimport '@testing-library/jest-dom'Checklist:
docs site N/A
Thank you for you made useful library & maintaining actively! 😀