Skip to content

Remove cleanup-after-each #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2020
Merged

Remove cleanup-after-each #598

merged 2 commits into from
Mar 4, 2020

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Mar 4, 2020 •
edited
Loading

It was deprecated in the last release, so we could safely delete it now I think 🙂

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 4, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7d97e2a:

Sandbox Source
intelligent-diffie-29qft Configuration
floral-glitter-ez36j Configuration

@codecov
Copy link

codecov bot commented Mar 4, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (beta@2d109ab). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             beta   #598   +/-   ##
=====================================
  Coverage        ?   100%           
=====================================
  Files           ?      3           
  Lines           ?    103           
  Branches        ?     15           
=====================================
  Hits            ?    103           
  Misses          ?      0           
  Partials        ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d109ab...7d97e2a. Read the comment docs.

kentcdodds
kentcdodds reviewed Mar 4, 2020
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Please also remove the listing in the package.json#files. Thanks!

@MichaelDeBoey MichaelDeBoey requested a review from kentcdodds March 4, 2020 19:49
kentcdodds
kentcdodds approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Thank you!

@kentcdodds kentcdodds merged commit 9bd87c6 into testing-library:beta Mar 4, 2020
@MichaelDeBoey MichaelDeBoey deleted the remove-cleanup-after-each branch March 4, 2020 19:52
@kentcdodds
Copy link
Member

@all-contributors please add @MichaelDeBoey for code

@allcontributors allcontributors bot mentioned this pull request Mar 4, 2020
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @MichaelDeBoey! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 10.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

kentcdodds added a commit that referenced this pull request Mar 4, 2020
@kentcdodds
fix: remove deprecated cleanup-after-each (#598)
feafc6f 
BREAKING CHANGE: This removes `@testing-library/react/cleanup-after-each` which is deprecated and hasn't done anything for many versions.
kentcdodds added a commit that referenced this pull request Mar 12, 2020
@kentcdodds
fix: remove deprecated cleanup-after-each (#598)
91d6256 
BREAKING CHANGE: This removes `@testing-library/react/cleanup-after-each` which is deprecated and hasn't done anything for many versions.
kentcdodds added a commit that referenced this pull request Mar 12, 2020
@kentcdodds
fix: remove deprecated cleanup-after-each (#598)
f0771a7 
BREAKING CHANGE: This removes `@testing-library/react/cleanup-after-each` which is deprecated and hasn't done anything for many versions.
kentcdodds added a commit that referenced this pull request Mar 12, 2020
@kentcdodds
fix: remove deprecated cleanup-after-each (#598)
b32782b 
BREAKING CHANGE: This removes `@testing-library/react/cleanup-after-each` which is deprecated and hasn't done anything for many versions.
kentcdodds added a commit that referenced this pull request Mar 12, 2020
@kentcdodds
fix: remove deprecated cleanup-after-each (#598)
d6d2f73 
BREAKING CHANGE: This removes `@testing-library/react/cleanup-after-each` which is deprecated and hasn't done anything for many versions.
kentcdodds added a commit that referenced this pull request Mar 12, 2020
@kentcdodds
fix: remove deprecated cleanup-after-each (#598)
7942f68 
BREAKING CHANGE: This removes `@testing-library/react/cleanup-after-each` which is deprecated and hasn't done anything for many versions.
@snyk-bot snyk-bot mentioned this pull request Apr 4, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @kentcdodds