[#78] Updated readme to add wait best practice #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you should exclude all those |
…ndation that was given by Kent in issue 78.
RyanAtViceSoftware
force-pushed
the
78-updated-readme-to-add-wait-best-practice
branch
from
a6f5473 to
686a58c
Compare
|
@gnapse updated to remove WebStorm files. Thanks for the |
kentcdodds
approved these changes
May 7, 2018
|
🎉 This PR is included in version 3.0.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
julienw
pushed a commit
to julienw/react-testing-library
that referenced
this pull request
Dec 20, 2018
* docs: added Using Without Jest section * use jsdom-global I discovered a package that can simplify this process greatly :)
lucbpz
pushed a commit
to lucbpz/react-testing-library
that referenced
this pull request
Jul 26, 2020
chore: 🤖 update react-testing-library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #78
What:
readme.mdwas updated to give the advice that @kentcdodds gave me in that issue around best practices for usingwait.Why:
I'm hoping to save other folks time ramping up on how to create valuable tests.
How:
Checklist: