Skip to content

Updates for the new scoped packages #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kentcdodds opened this issue May 31, 2019 · 8 comments
Closed

Updates for the new scoped packages #124

kentcdodds opened this issue May 31, 2019 · 8 comments

Comments

@kentcdodds
Copy link
Member

kentcdodds commented May 31, 2019

I believe most official packages are being migrated over to the scoped version and we need to update the docs to reflect this change.

Also, when talking about dom-testing-library, react-testing-library, and cypress-testing-library. I'm now referring to it as DOM Testing Library, React Testing Library, and Cypress Testing Library. The only time it should appear as @testing-library/dom is when we're talking about the module.

We'll need to update code samples as well as prose text throughout the docs.

I don't think we have to do it all at once, but if people could go around and update things a page/file at a time, that would be helpful!

@afontcu
Copy link
Member

afontcu commented May 31, 2019

up for it!

If I understood you correctly:

  • rename dom-testing-library to @testing-library/dom if talking about the npm module.
  • rename dom-testing-library to DOM Testing Library else.

and same thing with React, Cypress, and others (when migrated - not sure about the status. Vue is pending, for instance).

@kentcdodds
Copy link
Member Author

Correct.

I believe that React Native Testing Library and Jest Native are both already migrated as well 👍

@kentcdodds
Copy link
Member Author

Also, THANK YOU! :D

@alexkrolick
Copy link
Collaborator

alexkrolick commented May 31, 2019

@afontcu thanks for taking this on. I think we can do RTL and the other ones at the same time rather than having both usages. Want to add those to the PR if you're up for it?

@afontcu
Copy link
Member

afontcu commented Jun 1, 2019

@alexkrolick Sure, will do! I'll start with RTL, Cypress, and Vue and keep adding the ones without an alternative PR (Svelte and Testcafe are being updated too).

@afontcu
Copy link
Member

afontcu commented Jun 3, 2019

So what else is missing to finally close this issue? :) I believe all references have been updated, both in text and code snippets.

@kentcdodds
Copy link
Member Author

Thanks! Let's go ahead and close it then. Your help is really appreciated!

@kentcdodds
Copy link
Member Author

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants