Skip to content

Add docs on prettyDOM options parameter #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2019
Merged

Add docs on prettyDOM options parameter #181

merged 1 commit into from
Jul 9, 2019

Conversation

thomaslombart
Copy link

@thomaslombart thomaslombart commented Jul 9, 2019 •
edited
Loading

What

This PR intends to add documentation on the missing options parameter of prettyDOM.

It closes #178.

Changes

  • Specify that prettyDOM is built on top of pretty-format
  • Add the missing type of prettyDOM
  • Explains what options refers to

kentcdodds
kentcdodds approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 👍

@kentcdodds kentcdodds merged commit a32c092 into testing-library:master Jul 9, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @thomlom for docs

@allcontributors allcontributors bot mentioned this pull request Jul 9, 2019
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @thomlom! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Options parameter is missing in prettyDOM function
2 participants
@thomaslombart @kentcdodds