Skip to content

Replace React Redux recipe with Redux's recipe #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2020

Conversation

nickserv
Copy link
Member

@nickserv nickserv commented Sep 1, 2020

@MatanBobi has updated Redux's examples for Testing Library based on our recipe, and I think it would be easier to maintain the recipe by keeping it in one place in Redux (which has additional testing information) and redirecting from our existing page.

History: #570 (comment)

@nickserv nickserv marked this pull request as ready for review September 1, 2020 00:29
@nickserv
Copy link
Member Author

nickserv commented Sep 1, 2020

I had to keep the Markdown file for this page but replace it with a stub so Docusaurus would still keep it in the sidebar. This should work with Netlify redirects, but please let me know if there's a better way.

Copy link
Member

@MatanBobi MatanBobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is tricky, not that I think of a different way to do it but if the anchor connected-components will be removed we'll just redirect to the page (not that bad) but if the name of the markdown file will change we will have a broken link here.
I can't think of a different way to do it though..

@nickserv
Copy link
Member Author

nickserv commented Sep 1, 2020

Yea I don't think there's a way to fully avoid that issue, though it seems like Redux should be keeping the recipe URLs in place even with its doc reworks. I'll keep try to track of it just in case, and I'll update the heading anchor if reduxjs/redux#3876 is merged.

@nickserv nickserv mentioned this pull request Sep 1, 2020
6 tasks
@nickserv nickserv merged commit 51061dc into master Sep 6, 2020
@nickserv nickserv deleted the replace-react-redux-recipe branch September 6, 2020 18:38
@nickserv nickserv mentioned this pull request Sep 6, 2020
4 tasks
@nickserv
Copy link
Member Author

nickserv commented Sep 6, 2020

The redirect is broken and will be fixed in #598.

I'll keep this merged since the link still helps reduce duplication and it's just one extra click without a redirect.

nickserv added a commit that referenced this pull request Oct 4, 2020
nickserv added a commit that referenced this pull request Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants