-
Notifications
You must be signed in to change notification settings - Fork 112
feat: Remove Router/Vuex for Vue 3 #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c02aba6
Remove handling of router/vuex
afontcu 825d77a
Fix existing tests
afontcu 62ecfed
Mark types as deprecated
afontcu e39281f
Add simple vuex example
afontcu 1d026d4
Improve messaging
afontcu 400d9f4
Mark store as optional
afontcu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,20 @@ | ||
<template> | ||
<div> | ||
<h2>Counter</h2> | ||
<div> | ||
<button data-testid="decrementer" @click="decrement">-</button> | ||
<span data-testid="count-value">{{ count }}</span> | ||
<button data-testid="incrementer" @click="increment">+</button> | ||
</div> | ||
</div> | ||
</template> | ||
|
||
<script> | ||
import { mapActions, mapState } from 'vuex' | ||
|
||
export default { | ||
computed: { | ||
...mapState(['count']) | ||
}, | ||
|
||
methods: { | ||
...mapActions(['decrement', 'increment']) | ||
} | ||
} | ||
</script> | ||
<template> | ||
<h2>Counter</h2> | ||
<button data-testid="decrementer" @click="decrement">-</button> | ||
<span data-testid="count-value">{{ count }}</span> | ||
<button data-testid="incrementer" @click="increment">+</button> | ||
</template> | ||
|
||
<script> | ||
import {mapActions, mapState} from 'vuex' | ||
|
||
export default { | ||
computed: { | ||
...mapState(['count']), | ||
}, | ||
|
||
methods: { | ||
...mapActions(['decrement', 'increment']), | ||
}, | ||
} | ||
</script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
import {render} from '..' | ||
|
||
beforeEach(() => { | ||
jest.spyOn(console, 'warn').mockImplementation(() => {}) | ||
}) | ||
|
||
afterEach(() => { | ||
console.warn.mockRestore() | ||
}) | ||
|
||
test('warns on deprecated store option', () => { | ||
const Component = {template: `<div></div>`} | ||
|
||
render(Component, { | ||
store: 'anything', | ||
}) | ||
|
||
expect(console.warn).toHaveBeenCalledTimes(1) | ||
expect(console.warn).toHaveBeenCalledWith( | ||
expect.stringContaining( | ||
`Providing 'store' or 'routes' options is no longer available`, | ||
), | ||
) | ||
}) | ||
|
||
test('warns on deprecated routes option', () => { | ||
const Component = {template: `<div></div>`} | ||
|
||
render(Component, { | ||
routes: 'anything', | ||
}) | ||
|
||
expect(console.warn).toHaveBeenCalledTimes(1) | ||
expect(console.warn).toHaveBeenCalledWith( | ||
expect.stringContaining( | ||
`Providing 'store' or 'routes' options is no longer available`, | ||
), | ||
) | ||
}) |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.