Skip to content

Rename index file to simplify test imports #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2019
Merged

Rename index file to simplify test imports #26

merged 1 commit into from
May 31, 2019

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented May 28, 2019

Hi!

By renaming the sole file of vue-testing-library, and making use of jest' moduleDirectories, example tests might look a bit simpler. If this PR is merged, tests would be "copy-pastable" into another project.

btw, I assumed that modifying the main key in package.json would make everything work as expected. If that's not the case and you are still interested in this PR, point me to the right direction and I'll change it.

Thanks! 😃

@dfcook dfcook merged commit da9614a into testing-library:master May 31, 2019
@dfcook
Copy link
Collaborator

dfcook commented May 31, 2019

Thanks for your recent PRs, sorry it's taken a while to get around to looking at them.

@afontcu
Copy link
Member Author

afontcu commented May 31, 2019

@dfcook oh no, thank you! Really happy to help. Feel free to ping me if you need some help or if you know any area that could use some love!

@afontcu afontcu mentioned this pull request May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants