Switch nutils to vite build #226

seonglae · 2025-06-06T14:23:50Z

Summary

convert nutils from tsup to vite
add vite-plugin-dts to root deps
format vite config

Testing

pnpm test (fails: fetch failed)
pnpm build

https://chatgpt.com/codex/tasks/task_e_6842ca0173248327a02f307c5bfe9848

codesandbox · 2025-06-06T14:23:53Z

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

…-size

Copilot

Pull Request Overview

This PR converts the nutils build process from tsup to Vite while adding related plugin and configuration changes, and extends the Notion API and CLI export features.

Switched build tool and updated configuration in nutils (vite.config.ts, package.json, and removal of tsup.config.ts).
Added a new Notion API method (getPageBacklinks) along with corresponding tests and documentation updates.
Updated CLI export features with options for treemap and stats generation, though duplicate imports and redundant exports were introduced.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages/nutils/vite.config.ts	New Vite configuration replacing tsup
packages/nutils/tsup.config.ts	Tsup configuration removed
packages/nutils/package.json	Updated build and watch scripts to use Vite
packages/nreact/src/context.tsx	Added cleanup of falsy component values
packages/nreact/src/components/search-dialog.tsx	Modified debounce logic with an unexpected onInput attribute
packages/nclient/src/notion-api.ts	Added new getPageBacklinks method
packages/nclient/src/notion-api.test.ts	New tests for the backlinks feature
packages/nclient/readme.md	Documentation updated for backlinks
packages/cli/src/treemap.ts	Changes in treemap generation with a potential undefined variable
packages/cli/src/notion/export.ts	Extended export functionality with duplicate import statements
packages/cli/src/main.ts	Duplicate export statements added
package.json	Added vite-plugin-dts dependency

Comments suppressed due to low confidence (1)

packages/cli/src/treemap.ts:15

The removal of the computation for 'treemapDataBlocks' causes its later use in generateTreemapHTML to reference an undefined variable. Ensure that a proper blocks metric is computed or remove the corresponding usage.

-  const treemapDataBlocks = computeMetrics(pageTree, 'blocks')

Copilot · 2025-06-07T18:00:24Z

packages/nreact/src/components/search-dialog.tsx

@@ -19,6 +17,16 @@ const debounce = (func: (...args: any[]) => void, wait: number) => {
  }
 }

+    // debounce search calls so the expensive query only runs after typing stops
+    this._search = debounce(this._searchImpl.bind(this), 500)
+                    onInput={this._onChangeQuery}


The 'onInput={this._onChangeQuery}' attribute appears to be misplaced within the debounce function block. Consider moving it to the appropriate component JSX element to avoid unintended behavior.

Copilot · 2025-06-07T18:00:24Z

packages/cli/src/notion/export.ts

+      const stats = computeStats(tree)
+      await writeStats(`${this.folder}/stats.json`, stats)
+    }
+import { generateTreemaps, PageNode } from '../treemap'


A duplicate import of 'generateTreemaps' and 'PageNode' was introduced, which can lead to confusion and potential maintenance issues. Removing the redundant import should resolve this.

Suggested change

import { generateTreemaps, PageNode } from '../treemap'

Copilot · 2025-06-07T18:00:24Z

packages/cli/src/main.ts

+export * from './treemap'
+export * from './stats'


The duplicate export statement for './treemap' (and similarly for './stats') can cause redundancy and potential conflicts. Remove the extra export lines to keep the module exports clear.

Suggested change

export * from './treemap'

export * from './stats'

cursor

Bug: Duplicate Cleanup Logic Creates Dead Code

Duplicate code block for cleaning up falsy components. The logic to filter out falsy component values is duplicated, appearing both inside and immediately outside a React.useMemo callback. The original code outside the callback was not removed when the logic was moved inside, resulting in unreachable dead code.

packages/nreact/src/context.tsx#L190-L203

notion-node/packages/nreact/src/context.tsx

Lines 190 to 203 in 23a22d9

    
             } 
        
             // ensure the user can't override default components with falsy values 
        
             // since it would result in very difficult-to-debug react errors 
        
             for (const key of Object.keys(components)) if (!components[key]) delete components[key] 
        
             return components 
        
           }, [themeComponents]) 
        
             // ensure the user can't override default components with falsy values 
        
             // since it would result in very difficult-to-debug react errors 
        
             for (const key of Object.keys(components)) if (!components[key]) delete components[key] 
        
             return components 
        
           }, [themeComponents])

Fix in Cursor

Bug: Treemap Generation Fails Due to Syntax and Reference Errors

The generateTreemaps function is incomplete, causing a syntax error due to a missing closing brace. Additionally, it results in a runtime reference error because the treemapDataBlocks variable is used in a generateTreemapHTML call without being defined, as its declaration was removed. This prevents the blocktree.html generation feature from working.

packages/cli/src/treemap.ts#L14-L18

notion-node/packages/cli/src/treemap.ts

Lines 14 to 18 in 23a22d9

    
           await generateTreemapHTML(treemapDataPages, titlePages, outputPathPages) 
        
           const titleBlocks = 'Texonom BlockMap' 
        
           const outputPathBlocks = `${folder}/blocktree.html` 
        
           await generateTreemapHTML(treemapDataBlocks, titleBlocks, outputPathBlocks)

Fix in Cursor

Bug: Duplicate Test Case Causes Runner Conflicts

The "Page Backlink" test case is duplicated. An identical test is defined twice, leading to test runner conflicts due to duplicate test names and potentially masking test failures.

packages/nclient/src/notion-api.test.ts#L67-L73

notion-node/packages/nclient/src/notion-api.test.ts

Lines 67 to 73 in 23a22d9

    
           test(`Page Backlink`, { timeout: 10000, concurrent: true }, async () => { 
        
             const api = new NotionAPI({ authToken: process.env.NOTION_TOKEN }) 
        
             const backlinks = await api.getPageBacklinks('441d5ce2-b781-46d0-9354-54042b4f06d9') 
        
             expect(backlinks.backlinks.length > 0) 
        
           })

Fix in Cursor

Bug: Code Corruption: Duplicate and Malformed `debounce` Function

The commit introduces malformed code that prevents compilation. It includes a duplicate, fragmented implementation of the debounce utility function, featuring an incomplete statement, an orphaned onInput JSX attribute, and a misplaced function body.

packages/nreact/src/components/search-dialog.tsx#L19-L29

notion-node/packages/nreact/src/components/search-dialog.tsx

Lines 19 to 29 in 23a22d9

    
               // debounce search calls so the expensive query only runs after typing stops 
        
               this._search = debounce(this._searchImpl.bind(this), 500) 
        
                               onInput={this._onChangeQuery} 
        
             let timeout: ReturnType<typeof setTimeout> | undefined 
        
             return (...args: any[]) => { 
        
               if (timeout) clearTimeout(timeout) 
        
               timeout = setTimeout(() => func(...args), wait) 
        
             } 
        
           }

Fix in Cursor

Bug: Redundant Module Exports Cause Compilation Issues

Duplicate export statements for ./treemap and ./stats modules are present in packages/cli/src/main.ts. These redundant exports may cause compilation errors or unexpected module behavior.

packages/cli/src/main.ts#L20-L22

notion-node/packages/cli/src/main.ts

Lines 20 to 22 in 23a22d9

    
           export * from './stats' 
        
           export * from './treemap' 
        
           export * from './stats'

Fix in Cursor

Bug: Malformed File Structure Causes Compilation Failure

The file has a malformed structure with duplicate import statements for generateTreemaps, PageNode, computeStats, and writeStats. It also includes orphaned Option.Boolean property definitions (treemap, stats) that are incorrectly placed outside the NotionExportCommand class. This will prevent compilation.

packages/cli/src/notion/export.ts#L1-L31

notion-node/packages/cli/src/notion/export.ts

Lines 1 to 31 in 23a22d9

    
           import { Option, Command } from 'clipanion' 
        
           import { NotionExporter } from './index' 
        
           import { generateTreemaps, PageNode } from '../treemap' 
        
           import { computeStats, writeStats } from '../stats' 
        
             treemap = Option.Boolean('--treemap', { 
        
               description: 'Generate HTML treemap after export' 
        
             }) 
        
             stats = Option.Boolean('--stats', { 
        
               description: 'Generate statistics JSON after export' 
        
             }) 
        
               if (this.treemap || this.stats) if (!exporter.pageTree) await exporter.loadRaw() 
        
               const tree = exporter.pageTree as unknown as PageNode 
        
               if (this.treemap && tree) await generateTreemaps(this.folder, tree) 
        
               if (this.stats && tree) { 
        
                 const stats = computeStats(tree) 
        
                 await writeStats(`${this.folder}/stats.json`, stats) 
        
               } 
        
           import { generateTreemaps, PageNode } from '../treemap' 
        
           import { computeStats, writeStats } from '../stats' 
        
           export class NotionExportCommand extends Command { 
        
             static paths = [['export']] 
        
             folder = Option.String('-o,--output', 'texonom-raw', { 
        
               description: 'Target root folder to export folder' 
        
             }) 
        
             md = Option.String('-m,--md', 'texonom-md', { 
        
               description: 'Target folder to export markdown'

Fix in Cursor

BugBot free trial expires on June 13, 2025
You have used $0.00 of your $0.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

chore: format vite config

1769143

seonglae added the codex label Jun 6, 2025 — with ChatGPT Connector

seonglae self-assigned this Jun 6, 2025

seonglae added 2 commits June 6, 2025 16:06

Merge branch 'main' into codex/refactor-tsup-to-vite-and-reduce-build…

67fc000

…-size

merge: resolve conflicts with main

957ccd8

seonglae requested a review from Copilot June 7, 2025 17:59

Copilot AI reviewed Jun 7, 2025

View reviewed changes

chore: include vite-plugin-dts in nutils

23a22d9

cursor bot reviewed Jun 8, 2025

View reviewed changes

seonglae added 2 commits June 9, 2025 02:06

refactor: switch packages to vite

3b20cf1

docs: update build instructions for vite

754a75e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Switch nutils to vite build #226

Switch nutils to vite build #226

Uh oh!

seonglae commented Jun 6, 2025

Uh oh!

codesandbox bot commented Jun 6, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jun 7, 2025

Uh oh!

Copilot AI Jun 7, 2025

Uh oh!

Copilot AI Jun 7, 2025

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

	}
	// ensure the user can't override default components with falsy values
	// since it would result in very difficult-to-debug react errors
	for (const key of Object.keys(components)) if (!components[key]) delete components[key]

	return components
	}, [themeComponents])

	// ensure the user can't override default components with falsy values
	// since it would result in very difficult-to-debug react errors
	for (const key of Object.keys(components)) if (!components[key]) delete components[key]

	return components
	}, [themeComponents])

	await generateTreemapHTML(treemapDataPages, titlePages, outputPathPages)

	const titleBlocks = 'Texonom BlockMap'
	const outputPathBlocks = `${folder}/blocktree.html`
	await generateTreemapHTML(treemapDataBlocks, titleBlocks, outputPathBlocks)


	test(`Page Backlink`, { timeout: 10000, concurrent: true }, async () => {
	const api = new NotionAPI({ authToken: process.env.NOTION_TOKEN })
	const backlinks = await api.getPageBacklinks('441d5ce2-b781-46d0-9354-54042b4f06d9')
	expect(backlinks.backlinks.length > 0)
	})


	// debounce search calls so the expensive query only runs after typing stops
	this._search = debounce(this._searchImpl.bind(this), 500)
	onInput={this._onChangeQuery}
	let timeout: ReturnType<typeof setTimeout> \| undefined
	return (...args: any[]) => {
	if (timeout) clearTimeout(timeout)
	timeout = setTimeout(() => func(...args), wait)
	}
	}

	export * from './stats'
	export * from './treemap'
	export * from './stats'

	import { Option, Command } from 'clipanion'
	import { NotionExporter } from './index'
	import { generateTreemaps, PageNode } from '../treemap'
	import { computeStats, writeStats } from '../stats'
	treemap = Option.Boolean('--treemap', {
	description: 'Generate HTML treemap after export'
	})
	stats = Option.Boolean('--stats', {
	description: 'Generate statistics JSON after export'
	})

	if (this.treemap \|\| this.stats) if (!exporter.pageTree) await exporter.loadRaw()

	const tree = exporter.pageTree as unknown as PageNode
	if (this.treemap && tree) await generateTreemaps(this.folder, tree)

	if (this.stats && tree) {
	const stats = computeStats(tree)
	await writeStats(`${this.folder}/stats.json`, stats)
	}
	import { generateTreemaps, PageNode } from '../treemap'
	import { computeStats, writeStats } from '../stats'

	export class NotionExportCommand extends Command {
	static paths = [['export']]

	folder = Option.String('-o,--output', 'texonom-raw', {
	description: 'Target root folder to export folder'
	})
	md = Option.String('-m,--md', 'texonom-md', {
	description: 'Target folder to export markdown'

Uh oh!

Switch nutils to vite build #226

Are you sure you want to change the base?

Switch nutils to vite build #226

Uh oh!

Conversation

seonglae commented Jun 6, 2025

Summary

Testing

Uh oh!

codesandbox bot commented Jun 6, 2025

Review or Edit in CodeSandbox

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 7, 2025

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Duplicate Cleanup Logic Creates Dead Code

Bug: Treemap Generation Fails Due to Syntax and Reference Errors

Bug: Duplicate Test Case Causes Runner Conflicts

Bug: Code Corruption: Duplicate and Malformed `debounce` Function

Bug: Redundant Module Exports Cause Compilation Issues

Bug: Malformed File Structure Causes Compilation Failure

Uh oh!

Uh oh!