[POC] Implements support for URI parsing. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaylattice
commented
Mar 2, 2020
| // TODO -- sanitize `input` such that the last occurrence of ":" is replaced with a "<" | ||
| // e.g. "my:urn:here:some.attrPath" -> "my:urn:here<some.attrPath" | ||
| // This is hacky, but would allow us to support parsing URIs from attributePaths. | ||
|
|
There was a problem hiding this comment.
This could be a temporary hacky fix until we figure out what's wrong with apg-lib, but I think there would need to be similar sanitizations for compileFilter, compilePatchPath, etc.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #8,
This PR is very quick POC for optional URI support. This PR is not ready to merge, because it does not abide by the SCIM spec. In order to implement URI parsing, I had to change the delimiter from
":"to"<". If anyone knows how to fix the potential issue inapg-libdiscussed above, I would love some help.