Skip to content
This repository was archived by the owner on Apr 2, 2021. It is now read-only.

Improve performance of lazy validation message formatting (#6709) #1

Closed
wants to merge 1 commit into from
Closed

Improve performance of lazy validation message formatting (#6709) #1

wants to merge 1 commit into from

Conversation

fdintino
Copy link
Member

@fdintino fdintino commented Aug 3, 2020

Backport of c2293e9 (which fixes encode#6709) to the 3.9.x branch

obswork
obswork approved these changes Aug 3, 2020
View reviewed changes
Copy link

@obswork obswork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

dakrauth
dakrauth suggested changes Aug 3, 2020
View reviewed changes
Copy link

@dakrauth dakrauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the ticket for this? I strongly disapprove of adding more forks when we've worked so hard to to avoid and remove so many of them. Plus, we have a 3.10.x for Python 3 and Django 2.x, so I'm not even sure that we need this.

@fdintino fdintino closed this Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dakrauth dakrauth dakrauth requested changes

@obswork obswork obswork approved these changes

@defbyte defbyte Awaiting requested review from defbyte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fdintino @dakrauth @obswork @bluetech