Support for Float literals #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle Float Literal using BigDecimal
Accidentally made a type in the comment explaining Infinity and NaN, fixed that in this commit
|
WALAWalker doesn't capture canonical SIL instructions and that's why |
comparing pointers to fltSemantics
|
Hi @themaplelab/swift , is that PR still relevant? I see that @Leeleo3x says that this should be modified after #18. |
added check for float and double using if-statements
|
This is still relevant. The modification has been just merged into this PR. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding basic support for float literals
Issues: #8 #9
Resolves SR-NNNN.