-
-
Notifications
You must be signed in to change notification settings - Fork 474
Docs - new engine (contentlayer) #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs - new engine (contentlayer) #1096
Conversation
…onents in case of not found
…ge change and loss of context resulting in bad UX when navigating the app for something specific; reduce bounce rate
…ore multi-tab was implemented); rename `dismissable` to `dismissible`; rename burger-case file names to camelCase for easier DX name matching (mdx file -> tsx file -> exported variable name)
….js specific for now, and RSC support is here + code examples reflect if `'use client';` is needed or not
… beyond max-h overflow (done in SSR, no flicker)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1096 +/- ##
==========================================
- Coverage 99.54% 93.56% -5.99%
==========================================
Files 163 205 +42
Lines 6621 8546 +1925
Branches 401 468 +67
==========================================
+ Hits 6591 7996 +1405
- Misses 30 550 +520 ☔ View full report in Codecov by Sentry. |
… in `Component` interface NOTE: maybe handle classes in the card component with `aspectRatio` or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary
An overall improvement of the code structure, homepage and docs page, with a big emphasis on DX.
Changes
content/docs
mdx
files now have required variables:title
anddescription
that are used as page meta tagsmdx
files and extract code demos toexamples
(I know, I know, lots of files, but u'll thank me later)client.tsx
,server.tsx
) that are RSC friendly, those that are only client will only have theclient.tsx
tab, there are two reasons why:onClick
,onSubmit
(etc) props passed to it which require the component to be clientonClick
,onSubmit
, etc)mr-1
fromkbd
componentCodePreview
(now namedCodeDemo
) to support multiple tabs + multiple variants (check screenshots below)app/components
tocomponents
(root)app/data
todata
(root)<Flowbite>
wrapper since its redundant now.css
files and move them tostyles/
DocSearch
abstraction [less copy-paste]Result
Homepage - Before/After
Before
Screen.Recording.2023-10-31.at.17.38.27.mov
Screen.Recording.2023-10-31.at.17.39.30.mov
After
Screen.Recording.2023-10-31.at.17.39.57.mov
Screen.Recording.2023-10-31.at.17.39.47.mov
Docs - Before/After
Before
Screen.Recording.2023-10-31.at.17.36.33.mov
After
Screen.Recording.2023-10-31.at.17.37.09.mov
Usage - Docs
mdx
filescode examples structure
output
Code demo - multiple tabs
Screen.Recording.2023-10-31.at.17.45.43.mov
Build output differences
Before
After
mdx
files downsize