feat: Add disableSwipe prop to Carousel #1353
Conversation
|
@jsonMartin is attempting to deploy a commit to the Themesberg Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant Carousel
User->>Carousel: Start Drag
Carousel-->>User: Check disableSwipe
alt disableSwipe is true
Carousel-->>User: Swipe Disabled
else disableSwipe is false
Carousel-->>User: Swipe Enabled
end
Assessment against linked issues
Tip New Features and ImprovementsReview SettingsIntroduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. AST-based InstructionsCodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation. Community-driven AST-based RulesWe are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information. New Static Analysis ToolsWe are continually expanding our support for static analysis tools. We have added support for Tone SettingsUsers can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:
Revamped Settings PageWe have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to Miscellaneous
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/lib/carousel/Carousel.svelte (2 hunks)
Additional comments not posted (2)
src/lib/carousel/Carousel.svelte (2)
31-31: The declaration and default initialization ofdisableSwipeare correctly implemented.
118-119: The modification toonDragStartcorrectly implements the newdisableSwipefeature by preventing swipe actions whendisableSwipeis true.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for your contribution. |
Closes #1280
📑 Description
Exposes a new
disableSwipeprop, which allows control over whether or not swipe gestures are allowed to change slides within the Carousel.This PR is required because swiping slides interferes with scrolling gestures on mobile devices, resulting in full-screen Carousel components being unable to scroll without a border.
Status
✅ Checks
FATHOM_IDerror, but testing in browser & iOS simulator works as expected)ℹ Additional Information
Tested on iOS Simulator with iPhone 15 Pro Max device, works as intended. Slide swiping navigation is disabled and user can scroll through the page, but taps for button clicks and slides still work as expected.
Summary by CodeRabbit
disableSwipeoption to the carousel component, allowing users to disable swipe actions.