This repository was archived by the owner on May 12, 2018. It is now read-only.
[WIP] Update test suite #139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Updating the test suite introduced a few failing tests.
This test is not failing because it's recursive but because it requires the dereferencer to walk the current document before attempting to load it via the URI. See json-schema-org/JSON-Schema-Test-Suite#217 and json-schema-org/json-schema-spec#576.
This is failing because we are using
FILTER_VALIDATE_URLand it's a URI, not a URL. I probably need to pull in league/uri-parser but that will bump the minimum version to 7.0. I was considering doing that anyway.This is failing because we use php's PCRE regex instead of ECMA. I don't think it's worth trying to fix this, it's an optional test.