chore/numerous improvements #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
deathbywedgie
commented
May 7, 2022
deathbywedgie
commented
- various logic improvements
- fixed various typos
- fixed a potential bug with the to_str helper
- fixed a potential bug with the "compile" method of the "RegEx" custom class
- edited to comply with various PEP 8 best practices
- removed some custom types that do not serve a purpose
- improved some type hints
- raise correct exceptions
- split requirements.txt so that only true requirements for users to use the package are present, and moved all dev & test packages to requirements-dev.txt
- set "raw" string flags for regex wherever backslashes are used
…nd "is not" rather than "==" and "!=" https://www.flake8rules.com/rules/E711.html
…ly to raise type mismatch warnings.
…passed "list" types (lowercase). Both are valid, so added a Union to expect both to prevent type mismatch warnings.
… users of this module, and a new requirements-dev.txt contains all the packages collected for dev, testing, etc.
…ms with interpreting escapes
…d slash in most regex implementations, particularly with the re module
…t could be used by itself, and it causes type hint warnings, so just removed it
…re, so fixing while it is no impact
…lass without matching the base method's inputs, so added "args" and "kwargs" inputs.
…declaration serves no purpose
…d this is an internal-only method, so renaming to match other multi-word methods (such as "search" and "trim" in the same String class)
…auses a TypeError exception, because inspect is not directly callable. From context I assume this was meant to be "inspect.ismodule," and doing so resolves the error without breaking any tests.
… as a "self" object.
…h more flexible to use "isinstance" instead
theteladras
reviewed
May 11, 2022
…sion before merging this branch's PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.