Skip to content

client: Verify and fix the version comparison done for metadata files #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rdimitrov opened this issue Feb 10, 2022 · 3 comments
Closed

Comments

@rdimitrov
Copy link
Contributor

Description:

  • Verify the usage of “less than vs less than or equal to” done for version comparison throughout the code
  • The confusion comes that the spec uses the same text in multiple scenarios that are not the same
  • Meta versions can be equal, but metadata versions probably should not be. For everything other than timestamp, it does not matter. For timestamp, spec always expects to download the latest and use that.
  • For example, it’s normal for the timestamp version to change but still points to the same snapshot version.
  • Note that fixing this implies a change in the specification too.
@mnm678
Copy link
Collaborator

mnm678 commented Feb 10, 2022

Can you cross-post an issue to the specification repo? It'd be great to fix this there first so that we stay compliant with the spec.

@rdimitrov
Copy link
Contributor Author

Linked to #282

@rdimitrov
Copy link
Contributor Author

Closing this one in favour of #282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants