Skip to content

Verify and fix the version comparison done for metadata files #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rdimitrov opened this issue Feb 11, 2022 · 1 comment · Fixed by #209
Closed

Verify and fix the version comparison done for metadata files #207

rdimitrov opened this issue Feb 11, 2022 · 1 comment · Fixed by #209

Comments

@rdimitrov
Copy link
Contributor

Description:

  • Verify the usage of “less than vs less than or equal to” done for version comparison throughout the specification
  • The confusion comes that the spec uses the same text in multiple scenarios that are not the same
  • Meta versions can be equal, but metadata versions probably should not be. For everything other than timestamp, it does not matter. For timestamp, spec always expects to download the latest and use that
  • For example, it’s normal for the timestamp version to change but still point to the same snapshot version

Related issues:
@joshuagl
Copy link
Member

See related spec issue #114

rdimitrov added a commit to rdimitrov/specification that referenced this issue Feb 16, 2022
@rdimitrov
Rationalize the version comparison rules for when a client tries to u…
094fdd3 
…pdate the metadata files

The client workflow has a set of version comparisons rules for how to update metadata files.
Not all metadata files should be treated equal and the following PR address that.
Fixes theupdateframework#207 and is related to theupdateframework#114.

Signed-off-by: Radoslav Dimitrov <[email protected]>
rdimitrov added a commit to rdimitrov/specification that referenced this issue Feb 16, 2022
@rdimitrov
Update metadata version comparison rules in client workflow
94c5930 
The client workflow has a set of version comparisons rules for how
to update metadata files. The following PR addresses the differences
coming from the fact that when updating not all metadata files should
be treated equally.
Fixes theupdateframework#207 and is related to theupdateframework#114.

Signed-off-by: Radoslav Dimitrov <[email protected]>
@rdimitrov rdimitrov mentioned this issue Feb 16, 2022
Merged
rdimitrov added a commit to rdimitrov/specification that referenced this issue Feb 16, 2022
@rdimitrov
Update metadata version comparison rules in client workflow
b534008 
The client workflow has a set of version comparison rules for how
to update metadata files. The following PR addresses the differences
coming from the fact that when updating not all metadata files should
be treated equally.

Fixes theupdateframework#207 and is related to theupdateframework#114

Signed-off-by: Radoslav Dimitrov <[email protected]>
mnm678 pushed a commit that referenced this issue Apr 28, 2022
@rdimitrov @joshuagl
Update metadata version comparison rules in client workflow (#209)
7f356e4 
* Update metadata version comparison rules in client workflow

The client workflow has a set of version comparison rules for how
to update metadata files. The following PR addresses the differences
coming from the fact that when updating not all metadata files should
be treated equally.

Fixes #207 and is related to #114

Signed-off-by: Radoslav Dimitrov <[email protected]>

* Bump date and version to 1.0.29

Signed-off-by: Radoslav Dimitrov <[email protected]>

* Address what happens in case of equal metadata versions for client update

Signed-off-by: Radoslav Dimitrov <[email protected]>

* Update VERSION and Date

Co-authored-by: Joshua Lock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update metadata version comparison rules in client workflow rdimitrov/specification
2 participants
@joshuagl @rdimitrov