Update ngclient to skip visited nodes on delegation tree traversal

This change edits the ngclient `Updater` to traverse the delegation
tree on nodes, instead of edges in order to skip already visited
nodes.

For more detailed clarification, please review
theupdateframework/specification#177

Fixes #1528

Signed-off-by: Ivana Atanasova <[email protected]>

Author: Ivana Atanasova

tuf/ngclient/updater.py

@@ -62,7 +62,7 @@
 import logging
 import os
 import tempfile
-from typing import Optional, Set, Tuple
+from typing import Optional, Set
 from urllib import parse
 
 from securesystemslib import util as sslib_util
@@ -401,17 +401,19 @@ def _preorder_depth_first_walk(
         # List of delegations to be interrogated. A (role, parent role) pair
         # is needed to load and verify the delegated targets metadata.
         delegations_to_visit = [("targets", "root")]
-        visited_role_names: Set[Tuple[str, str]] = set()
+        visited_role_names: Set[str] = set()
         number_of_delegations = self.config.max_delegations
 
         # Preorder depth-first traversal of the graph of target delegations.
         while number_of_delegations > 0 and len(delegations_to_visit) > 0:
 
             # Pop the role name from the top of the stack.
             role_name, parent_role = delegations_to_visit.pop(-1)
+            if parent_role not in visited_role_names:
+                visited_role_names.add(parent_role)
 
             # Skip any visited current role to prevent cycles.
-            if (role_name, parent_role) in visited_role_names:
+            if role_name in visited_role_names:
                 logger.debug("Skipping visited current role %s", role_name)
                 continue
 
@@ -427,7 +429,7 @@ def _preorder_depth_first_walk(
                 return target
 
             # After preorder check, add current role to set of visited roles.
-            visited_role_names.add((role_name, parent_role))
+            visited_role_names.add(role_name)
 
             # And also decrement number of visited roles.
             number_of_delegations -= 1