-
Notifications
You must be signed in to change notification settings - Fork 280
Closed
Labels
backlogIssues to address with priority for current development goalsIssues to address with priority for current development goalsgood first issueBite-sized items for first time contributorsBite-sized items for first time contributorsngclient
Milestone
Description
spec says (for each role in delegation tree):
If this role has been visited before, then skip this role
ngclient does:
if (role_name, parent_role) in visited_role_names:
logger.debug("Skipping visited current role %s", role_name)
continue
So it only skips if role has been visited from same parent. If there is a good reason for allowing the same role multiple times in the delegation tree (against the spec), it should be documented somehow. Alternatively we should do what the spec says and make visited_role_names just a set of role names (and not a set of tuple)...
Pinging @sechkova for comment: there's probably a reason ngclient does this (considering legacy client does not do this), happen to remember what it is?
Metadata
Metadata
Assignees
Labels
backlogIssues to address with priority for current development goalsIssues to address with priority for current development goalsgood first issueBite-sized items for first time contributorsBite-sized items for first time contributorsngclient