Skip to content

tests: consistent_snapshot tests in test_updater_ng.py are broken #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jku opened this issue Sep 8, 2021 · 0 comments · Fixed by #1666
Closed

tests: consistent_snapshot tests in test_updater_ng.py are broken #1573

jku opened this issue Sep 8, 2021 · 0 comments · Fixed by #1666
Assignees
Labels
backlog Issues to address with priority for current development goals ngclient testing
Milestone

Comments

@jku
Copy link
Member

jku commented Sep 8, 2021

test_refresh_on_consistent_targets() does not actually try to refresh any metadata apart from root and timestamp (and it couldn't because the files don't exist in the repository). The test only passes because client already has all the metadata in the metadata cache.

I'm not sure it makes sense to fix this before #1444 but I'm filing so we don't make this mistake again.

jku pushed a commit to jku/python-tuf that referenced this issue Sep 8, 2021
Do not add similar assertions for test_refresh_on_consistent_targets():
The test is broken and can't actually update metadata (theupdateframework#1573).

Signed-off-by: Jussi Kukkonen <[email protected]>
jku pushed a commit to jku/python-tuf that referenced this issue Sep 8, 2021
Do not add similar assertions for test_refresh_on_consistent_targets():
The test is broken and can't actually update metadata (theupdateframework#1573).

Signed-off-by: Jussi Kukkonen <[email protected]>
jku pushed a commit to jku/python-tuf that referenced this issue Sep 8, 2021
Do not add similar assertions for test_refresh_on_consistent_targets():
The test is broken and can't actually update metadata (theupdateframework#1573).

Signed-off-by: Jussi Kukkonen <[email protected]>
@sechkova sechkova added testing ngclient backlog Issues to address with priority for current development goals labels Sep 9, 2021
@sechkova sechkova self-assigned this Nov 17, 2021
@sechkova sechkova added this to the Sprint 12 milestone Nov 17, 2021
@jku jku closed this as completed in #1666 Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issues to address with priority for current development goals ngclient testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants