Skip to content

tests: test_update_root_new_root_fail_threshold_verification is misleading #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jku opened this issue Jan 5, 2022 · 0 comments · Fixed by #1936
Closed

tests: test_update_root_new_root_fail_threshold_verification is misleading #1753

jku opened this issue Jan 5, 2022 · 0 comments · Fixed by #1936
Labels

Comments

@jku
Copy link
Member

jku commented Jan 5, 2022

test_trusted_metadata_set.py: test_update_root_new_root_fail_threshold_verification():

  • test does not sign the metadata it modifies at all: loading metadata with completely wrong signatures of course fails as expected... but the test really implies this is related to the keyid change
  • it's not clear which threshold verification is being tested (whether the current roots threshold fails or the new roots threshold fails) -- a test for each might be useful

these tests might also be more useful if they increased the threshold by 1 (and re-signed), instead of clearing the keyids. This would allow one signature to be valid but the threshold to fail because there are not enough signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant