Metadata API: Make Role.keyids ordered #1754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This modifies test_update_root_new_root_fail_threshold_verification() which seems broken to me: I left that for #1753 |
Pull Request Test Coverage Report for Build 1657734798Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
MVrachev
approved these changes
Jan 5, 2022
keyids are ordered in the data we deserialize: Not preserving that order breaks canonicalization. Set does not preserve order. Change Role.keyids type from Set to List. This is strictly speaking an API change but a minor one: keyids are supposed to be changed via add_key()/remove_key(). Add tests for this for both Role and DelegatedRole. Shorten a related exception message. Fix theupdateframework#1752 Signed-off-by: Jussi Kukkonen <[email protected]>
jku
force-pushed
the
role-keyids-order-fix
branch
from
85ca3c2 to
80d3fcf
Compare
|
focre-pushed: Only change is a string marked as f-string |
joshuagl
approved these changes
Jan 5, 2022
| f" instead got {keyids}" | ||
| ) | ||
| if len(set(keyids)) != len(keyids): | ||
| raise ValueError(f"Nonunique keyids: {keyids}") |
There was a problem hiding this comment.
Small nit, feel free to ignore
Suggested change
| raise ValueError(f"Nonunique keyids: {keyids}") | |
| raise ValueError(f"Non-unique keyids: {keyids}") |
|
Looks good to me. |
|
I will live with nonunique since there's no other changes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keyids are ordered in the data we deserialize: Not preserving that order
breaks canonicalization. Set does not preserve order.
Change Role.keyids type from Set to List. This is strictly speaking
an API change but a minor one: keyids are supposed to be changed
via add_key()/remove_key().
Add tests for this for both Role and DelegatedRole. Shorten a related
exception message.
Fix #1752
Signed-off-by: Jussi Kukkonen [email protected]
Please verify and check that the pull request fulfills the following
requirements: