Skip to content

The client-example has a confusing return for the download function. #2056

@kairoaraujo

Description

@kairoaraujo

Description of issue:
The client-example has a confusing return for the download function.
The return mixes the error and flows handling.

Current behavior:
Currently, it returns a bool.

  • If a target file is downloaded it returns True
  • If there is an exception in the code it returns False
  • if a target file is not found it returns True

Expected behavior:
The return code only manages the exceptions. However, there is no use for the current return.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions