Skip to content

Consistent versions of root appear to be needlessly written multiple times #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vladimir-v-diaz opened this issue Nov 2, 2016 · 2 comments
Closed

Consistent versions of root appear to be needlessly written multiple times #391

vladimir-v-diaz opened this issue Nov 2, 2016 · 2 comments

Comments

@vladimir-v-diaz
Copy link
Contributor

write_metadata_file() was modified in PRs #379 and #383 to always write root.json and <version>.root.json if consistent snapshots = True. Given these changes, we should refactor the following lines: https://github.com/theupdateframework/tuf/blob/0ce016b7b19a0fc15443eed657a90246ec5df0aa/tuf/repository_lib.py#L213-L224

Log files and a closer inspection of this code show that multiple attempts are made to write root.json.

Thanks given to @FelixWang1994 for bringing this issue to our attention.
FelixWang1994 added a commit to FelixWang1994/tuf that referenced this issue Nov 2, 2016
@FelixWang1994
Fix Issue theupdateframework#391
202c74d
@FelixWang1994 FelixWang1994 mentioned this issue Nov 2, 2016
Merged
@vladimir-v-diaz vladimir-v-diaz mentioned this issue Nov 4, 2016
Closed
vladimir-v-diaz added a commit that referenced this issue Nov 7, 2016
@vladimir-v-diaz
Merge pull request #392 from FelixWang1994/develop
75f4ef6 
Fix Issue #391
@vladimir-v-diaz
Copy link
Contributor Author

This issue was fixed in #392 and #394

@FelixWang1994
Thanks for working on this issue.

@FelixWang1994
Copy link
Contributor

FelixWang1994 commented Nov 7, 2016 •
edited
Loading

My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vladimir-v-diaz @FelixWang1994