Skip to content

Fix typo in comment #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2020
Merged

Fix typo in comment #1021

merged 1 commit into from
May 27, 2020

Conversation

MVrachev
Copy link
Collaborator

Signed-off-by: Martin Vrachev [email protected]

@@ -1476,7 +1476,7 @@ def generate_snapshot_metadata(metadata_directory, version, expiration_date,
metadata_directory = _check_directory(metadata_directory)

# Snapshot's 'fileinfodict' shall contain the version number of Root,
# Targets, and all delegated roles fo the repository.
# Targets, and all delegated roles to the repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't "of" make more sense?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, a good point.
I am not a native english speaker and sometimes I make mistakes like that one. :D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes two of use. ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, no, me three...

@MVrachev
Copy link
Collaborator Author

MVrachev commented Apr 16, 2020

Squashed my commits and rebased on develop.

Signed-off-by: Martin Vrachev <[email protected]>
Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci! :)

@lukpueh lukpueh merged commit 580334e into theupdateframework:develop May 27, 2020
@joshuagl joshuagl mentioned this pull request Aug 4, 2020
3 tasks
@MVrachev MVrachev deleted the patch-1 branch August 4, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants