Remove future module #1342
Merged
Remove future module #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, commit looks good. Would you mind getting rid of the extra merge branch 'develop' commit though? I think a rebase on top of develop should do that (and force pushing to this remove-future-module branch is fine). |
KainaatSingh
force-pushed
the
remove-future-module
branch
from
cc32893 to
935d32b
Compare
Signed-off-by: Kainaat Singh <[email protected]> remove unwanted lines
KainaatSingh
force-pushed
the
remove-future-module
branch
from
935d32b to
ec68bd9
Compare
|
@jku Thanks for the feedback! I have made the required changes. I have incorporated the latest commits from the main code as well. Let me know if it looks okay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1297
Description of the changes being introduced by the pull request:
Removes 168 occurrences of pattern
from_future_importfrom 43 files.With the release of tuf 0.17.0, Python2 is not supported. Therefore, backward compatibility of Python2 by importing future module is not required.
Please verify and check that the pull request fulfills the following
requirements: