Skip to content

Remove future module #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

KainaatSingh
Copy link
Contributor

@KainaatSingh KainaatSingh commented Apr 8, 2021

Fixes #1297

Description of the changes being introduced by the pull request:
Removes 168 occurrences of pattern from_future_import from 43 files.

With the release of tuf 0.17.0, Python2 is not supported. Therefore, backward compatibility of Python2 by importing future module is not required.

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@jku
Copy link
Member

jku commented Apr 9, 2021

Thanks, commit looks good.

Would you mind getting rid of the extra merge branch 'develop' commit though? I think a rebase on top of develop should do that (and force pushing to this remove-future-module branch is fine).

@KainaatSingh KainaatSingh force-pushed the remove-future-module branch from cc32893 to 935d32b Compare April 11, 2021 09:34
Signed-off-by: Kainaat Singh <[email protected]>

remove unwanted lines
@KainaatSingh KainaatSingh force-pushed the remove-future-module branch from 935d32b to ec68bd9 Compare April 11, 2021 09:38
@KainaatSingh
Copy link
Contributor Author

@jku Thanks for the feedback! I have made the required changes. I have incorporated the latest commits from the main code as well.

Let me know if it looks okay!

Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work, LGTM!

@jku jku merged commit 313c2a4 into theupdateframework:develop Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove uses of from __future__ import
2 participants