github: explicitly set workflow permissions #1663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* current workflow only needs to read git content * if the workflow in the future does need write access, it's good to see permissions explicitly changing For context: "pull_request" runs never have write access anyway, so this significantly changes only the "push" runs that happen when branches are merged to develop. Signed-off-by: Jussi Kukkonen <[email protected]>
Pull Request Test Coverage Report for Build 1420674927
💛 - Coveralls |
|
For anyone wondering: you can see the permissions by going to the job logs, opening "Set up job", then opening "GITHUB_TOKEN Permissions" |
Closed
Pull Request Test Coverage Report for Build 1420674927Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see permissions explicitly changing
For context: "pull_request" runs never have any write access anyway, so this
significantly changes only the "push" runs that happen when branches are
merged to develop.
Signed-off-by: Jussi Kukkonen [email protected]
Fixes #1662