Skip to content

test: add missing return type hint in test method #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lukpueh
Copy link
Member

@lukpueh lukpueh commented Dec 10, 2021

Fixes #

Description of the changes being introduced by the pull request:

Following parallel merges of #1700 (added new test method), and #1710 (started running mypy on tests), ci/cd fails in the develop branch. This is fixed in this patch.

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Following parallel merges of theupdateframework#1700 (added new test method),
and theupdateframework#1710 (started running mypy on tests), ci/cd fails in the
develop branch. This is fixed in this patch.

Signed-off-by: Lukas Puehringer <[email protected]>
@coveralls
Copy link

coveralls commented Dec 10, 2021

Pull Request Test Coverage Report for Build 1562850434

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 98.562%

Totals Coverage Status
Change from base Build 1562780344: 1.0%
Covered Lines: 3931
Relevant Lines: 3958

💛 - Coveralls

@lukpueh lukpueh merged commit 03cf333 into theupdateframework:develop Dec 10, 2021
@lukpueh lukpueh mentioned this pull request Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants