-
Notifications
You must be signed in to change notification settings - Fork 278
Start linting tuf/exceptions.py with all linters #1721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We are already using tuf/exceptions.py inside - tuf/api/metadata.py - tuf/ngclient/__internal__/trusted_metadata_set.py - tuf/ngclient/fetcher.py - tuf/ngclient/updater.py and in our tests that this means we are most likely going to use that module after we remove the old code. It make sense to lint it with the other three linters besides mypy (we already lint tuf/exceptions.py with mypy). Signed-off-by: Martin Vrachev <[email protected]>
Signed-off-by: Martin Vrachev <[email protected]>
There was one difficulty with pylint that adding tuf/exceptions.py to the list of ignores didn't work. That's why I found a different way to disable all pylint warnings with the "--disables=W" option. Signed-off-by: Martin Vrachev <[email protected]>
Pull Request Test Coverage Report for Build 1564745748Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have some commented code as 'Directly instance-repoducing'. Any reason to keep it?
Alternatively
I'm not saying this needs to all happen in one PR, but if you start with making the copy and removing old code, then there's far less code to fix/review and you don't need to deal with pylint disables: the way the PR handles disables almost certainly disabled warnings from all of the old code base, not just exceptions.py |
Yes, I can create a new module in |
Description of the changes being introduced by the pull request:
We are already using tuf/exceptions.py inside
tuf/api/metadata.py
tuf/ngclient/__internal__/trusted_metadata_set.py
tuf/ngclient/fetcher.py
tuf/ngclient/updater.py
This means that we are most likely going to use that
module after we remove the old code.
It makes sense to lint it with the other three
linters besides
mypy
(we already lint tuf/exceptions.py withmypy
).Please verify and check that the pull request fulfills the following
requirements: