Skip to content

Revert "github: disable pip caching temporarily" #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

jku
Copy link
Member

@jku jku commented Feb 4, 2022

This reverts commit 55d6cb4.

According to changelog setup-python v2.3.2 should include a workaround
for the issue.

@coveralls
Copy link

coveralls commented Feb 4, 2022

Pull Request Test Coverage Report for Build 1799131084

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.89%

Totals Coverage Status
Change from base Build 1795054635: 0.0%
Covered Lines: 1112
Relevant Lines: 1132

💛 - Coveralls

@lukpueh
Copy link
Member

lukpueh commented Feb 4, 2022

Heureka! 🎉 Can you squash, signoff and we merge this?

@jku
Copy link
Member Author

jku commented Feb 4, 2022

I had to pin 2.3.2 but I only did that because they forgot to move v2 tag.

Now maybe we should pin actions versions (?) but let's not decide that in a workaround: let's wait until v2 exists and then I remove the last commit from here

@joshuagl
Copy link
Member

joshuagl commented Feb 4, 2022

Now maybe we should pin actions versions (?) but let's not decide that in a workaround: let's wait until v2 exists and then I remove the last commit from here

I believe we should pin actions versions (we do in the specification)

@jku jku force-pushed the revert-pip-cache-disable branch from e9c4c83 to 4567a2f Compare February 5, 2022 10:29
This reverts commit 55d6cb4.

According to changelog setup-python v2.3.2 should include a workaround
for the issue.

Signed-off-by: Jussi Kukkonen <[email protected]>
@jku jku force-pushed the revert-pip-cache-disable branch from 4567a2f to 1a59b29 Compare February 5, 2022 10:30
@jku jku marked this pull request as ready for review February 5, 2022 10:36
@jku
Copy link
Member Author

jku commented Feb 5, 2022

I believe we should pin actions versions (we do in the specification)

I suppose you are right: #1826

setup-python v2 tag has been updated, this PR is good to go.

@lukpueh lukpueh merged commit 1c46eeb into theupdateframework:develop Feb 7, 2022
@coveralls
Copy link

coveralls commented Dec 29, 2024

Pull Request Test Coverage Report for Build 1794719306

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 98.556%

Totals Coverage Status
Change from base Build 1794362757: 0.9%
Covered Lines: 3948
Relevant Lines: 3977

💛 - Coveralls

@jku jku deleted the revert-pip-cache-disable branch December 30, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants