Awwad detect expiry 322 clean #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onflicts. Comment lines from the individual commits include: 1. Fix theupdateframework#322 by detecting expiry of stale files. initial attempt 2. temp commit of files from Soma 3. removing freeze_attack_stale_expiry and leaving the test added to indefinite freeze attack 4. fixing indefinite freeze attack test: now incorporates old reject-freshly-downloaded-but-expired-timestamp test as well as reject-stale-already-present-but-expired-snapshot test 5. small refinements to indefinite freeze attack test 6. Pulled the recursion out of the except block in refresh() to avoid unprintable nested exceptions. 7. Added comments to the last commit (retry_once) 8. Merge pull request #1 from awwad/detect_expiry_322_temp (removing cruft in another branch)
…had passed. (updater.refresh() can take a while.) - Put code back into working state after some failure mode debugging of a separate bug by Vlad and me. - Expanded some comments, added explanations, and made a few others more readable. - Removed an unnecessary path recalculation and an unnecessary sleep.
vladimir-v-diaz
added a commit
that referenced
this pull request
Mar 17, 2016
…clean Awwad detect expiry 322 clean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Issue #322. Please see that issue!
It replaces PRs #323 and #324.
This PR also:
For the full comment history on this pull request, see this PR.