Have repository_tool.get_filepaths_in_directory use absolute paths #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as its docstring says that it does. I'm not sure if this changed through some accident along the way, but in any case, before this commit, the docstring said that it yielded a list of absolute paths, but it did not. Now it does. Signed-off-by: Sebastien Awwad <[email protected]>
awwad
added a commit
that referenced
this pull request
Aug 20, 2018
(that is, despite currently existing issue to be remedied in #774) Currently, repository_tool.get_filepaths_in_directory yields relative paths, not the absolute paths it promises in its docstring. This test will now function despite this and continue to function after #774 is merged. Signed-off-by: Sebastien Awwad <[email protected]>
The test for repository_tool.get_filepaths_in_directory now expects absolute paths, and also now tests the *results* of the function's use when the recursive flag is on. Signed-off-by: Sebastien Awwad <[email protected]>
awwad
changed the title
awwad
added a commit
that referenced
this pull request
Aug 21, 2018
(that is, despite currently existing issue to be remedied in #774) Currently, repository_tool.get_filepaths_in_directory yields relative paths, not the absolute paths it promises in its docstring. This test will now function despite this and continue to function after #774 is merged. Signed-off-by: Sebastien Awwad <[email protected]>
Closed
lukpueh
pushed a commit
to lukpueh/tuf
that referenced
this pull request
Nov 11, 2019
…mework#774 (that is, despite currently existing issue to be remedied in theupdateframework#774) Currently, repository_tool.get_filepaths_in_directory yields relative paths, not the absolute paths it promises in its docstring. This test will now function despite this and continue to function after theupdateframework#774 is merged. Signed-off-by: Sebastien Awwad <[email protected]>
lukpueh
pushed a commit
to lukpueh/tuf
that referenced
this pull request
Nov 19, 2019
…mework#774 (that is, despite currently existing issue to be remedied in theupdateframework#774) Currently, repository_tool.get_filepaths_in_directory yields relative paths, not the absolute paths it promises in its docstring. This test will now function despite this and continue to function after theupdateframework#774 is merged. Signed-off-by: Sebastien Awwad <[email protected]>
lukpueh
pushed a commit
that referenced
this pull request
Dec 16, 2019
(that is, despite currently existing issue to be remedied in #774) Currently, repository_tool.get_filepaths_in_directory yields relative paths, not the absolute paths it promises in its docstring. This test will now function despite this and continue to function after #774 is merged. Signed-off-by: Sebastien Awwad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
I'm not sure if this changed through some accident along the way, but in any case, before this PR, the docstring for
repository_tool.get_filepaths_in_directory()said that it yielded a list of absolute paths, but it did not. Now it does.Fixes issue #: No prior issue identified
Please verify and check that the pull request fulfills the following
requirements: