Skip to content

Move TAP 12 to accepted #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

mnm678
Copy link
Contributor

@mnm678 mnm678 commented Mar 4, 2022

This pr proposes moving TAP 12 to accepted.

Requires #151

@mnm678 mnm678 requested review from joshuagl and lukpueh April 28, 2022 18:52
@joshuagl
Copy link
Member

The Augmented Reference Implementation section of the TAP lists "TODO", how close are current python-tuf and go-tuf to the behaviour described here?

Once the TAP is Accepted, should we file issues (or pull requests) against those projects to match the TAP?

@mnm678
Copy link
Contributor Author

mnm678 commented Apr 28, 2022

I believe the new python-tuf client is already compliant with this TAP as it does not verify keyids by the hash algorithm. That was added to the Augmented Reference Implementation section in #151.

There is an open issue in go-tuf for this TAP that we will want to address when this is accepted.

@joshuagl
Copy link
Member

Thank you. I thought we had discussed it but couldn't see that reflected in the branch the PR was opened from? 🤷‍♂️

Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see a TAP moving. Let's push to get this through to Final.

@mnm678 mnm678 merged commit b17ca48 into theupdateframework:master Apr 29, 2022
@mnm678 mnm678 deleted the tap12-acceptance branch April 29, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants