Skip to content

Conversation

saminacodes
Copy link
Member

@saminacodes saminacodes commented May 19, 2025

CORE-0000


PR-Codex overview

This PR updates the pricing information in the page.mdx file for Engine Cloud, clarifying the calculation of costs and modifying the legacy pricing note.

Detailed summary

  • Updated the pricing calculation to include sign requests alongside write requests.
  • Clarified that both write and sign requests cost $1 per 1,000 requests.
  • Revised the note about legacy pricing plans to specify a 10% fee when signed up instead of 5%, with a link to the pricing page.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@saminacodes saminacodes requested review from a team as code owners May 19, 2025 15:18
Copy link

changeset-bot bot commented May 19, 2025

⚠️ No Changeset found

Latest commit: 713ebe0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 3:52pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) May 19, 2025 3:52pm
thirdweb_playground ⬜️ Skipped (Inspect) May 19, 2025 3:52pm
thirdweb-www ⬜️ Skipped (Inspect) May 19, 2025 3:52pm
wallet-ui ⬜️ Skipped (Inspect) May 19, 2025 3:52pm

Copy link
Contributor

graphite-app bot commented May 19, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label May 19, 2025
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.28%. Comparing base (bfdac10) to head (713ebe0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7080   +/-   ##
=======================================
  Coverage   55.28%   55.28%           
=======================================
  Files         904      904           
  Lines       58499    58499           
  Branches     4069     4069           
=======================================
  Hits        32343    32343           
  Misses      26051    26051           
  Partials      105      105           
Flag Coverage Δ
packages 55.28% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 19, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 56.29 KB (0%) 1.2 s (0%) 195 ms (+163.34% 🔺) 1.4 s
thirdweb (cjs) 304.46 KB (0%) 6.1 s (0%) 600 ms (+12.07% 🔺) 6.7 s
thirdweb (minimal + tree-shaking) 5.69 KB (0%) 114 ms (0%) 55 ms (+607.65% 🔺) 169 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 15 ms (+498.66% 🔺) 26 ms
thirdweb/react (minimal + tree-shaking) 19.51 KB (0%) 391 ms (0%) 76 ms (+479.17% 🔺) 466 ms

@vercel vercel bot temporarily deployed to Preview – wallet-ui May 19, 2025 15:42 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 19, 2025 15:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 19, 2025 15:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 19, 2025 15:42 Inactive
@saminacodes saminacodes added the merge-queue Adds the pull request to Graphite's merge queue. label May 19, 2025
Copy link
Member Author

saminacodes commented May 19, 2025

Merge activity

CORE-0000

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the FAQ section in the `page.mdx` file regarding pricing calculations for Engine Cloud. It clarifies the types of requests that incur costs and modifies the note about legacy pricing plans.

### Detailed summary
- Updated pricing calculation to include both write and sign requests.
- Changed the cost description for requests to specify both write and sign requests.
- Revised the note on legacy pricing plans to include a link to the pricing page and clarify the fee specifics.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the saminacodes-patch-1 branch from 02ac82b to 713ebe0 Compare May 19, 2025 15:51
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 19, 2025 15:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 19, 2025 15:51 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 19, 2025 15:51 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 19, 2025 15:51 Inactive
@graphite-app graphite-app bot merged commit 713ebe0 into main May 19, 2025
22 checks passed
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label May 19, 2025
@graphite-app graphite-app bot deleted the saminacodes-patch-1 branch May 19, 2025 15:54
@vercel vercel bot temporarily deployed to Production – login May 19, 2025 15:54 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui May 19, 2025 15:54 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www May 19, 2025 15:54 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground May 19, 2025 15:54 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants