Fix: Transfer purchase data #7202

gregfromstl · 2025-05-29T16:51:32Z

PR-Codex overview

This PR focuses on fixing a bug related to the inclusion of purchaseData in PayEmbed transfers within the thirdweb package.

Detailed summary

Added purchaseData: params.purchaseData to the transfer parameters in the getTransfer.ts file.
This change ensures that purchaseData is included during PayEmbed transfers, addressing the identified bug.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Bug Fixes
- Fixed an issue where purchase details were not included in PayEmbed transfers, ensuring all relevant purchase data is now properly transferred.

changeset-bot · 2025-05-29T16:51:37Z

🦋 Changeset detected

Latest commit: a5942f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/wagmi-adapter	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-05-29T16:51:38Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 29, 2025 5:00pm
login	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 29, 2025 5:00pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 29, 2025 5:00pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 29, 2025 5:00pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 29, 2025 5:00pm

graphite-app · 2025-05-29T16:51:40Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

coderabbitai · 2025-05-29T16:51:40Z

Walkthrough

A bug was fixed to ensure that the purchaseData property is now included in PayEmbed transfers. The update modifies the transfer preparation process in the buy-with-crypto flow, forwarding the purchaseData metadata as part of the transfer parameters.

Changes

File(s)	Change Summary
packages/thirdweb/src/pay/buyWithCrypto/getTransfer.ts	Added `purchaseData` to the transfer preparation parameters.
.changeset/upset-views-show.md	Added a changeset describing the bug fix for missing `purchaseData`.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PayEmbed
    participant getBuyWithCryptoTransfer
    participant Transfer

    User->>PayEmbed: Initiate crypto purchase
    PayEmbed->>getBuyWithCryptoTransfer: Prepare transfer (with purchaseData)
    getBuyWithCryptoTransfer->>Transfer: prepare({..., purchaseData})
    Transfer-->>getBuyWithCryptoTransfer: Return transfer quote
    getBuyWithCryptoTransfer-->>PayEmbed: Return prepared transfer
    PayEmbed-->>User: Continue with purchase flow

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff3a79c and a5942f0.

📒 Files selected for processing (2)

.changeset/upset-views-show.md (1 hunks)
packages/thirdweb/src/pay/buyWithCrypto/getTransfer.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: Size
GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: Build Packages
GitHub Check: Lint Packages
GitHub Check: Unit Tests
GitHub Check: Analyze (javascript)

🔇 Additional comments (2)

packages/thirdweb/src/pay/buyWithCrypto/getTransfer.ts (1)

136-136: LGTM! Clean bug fix.

This correctly forwards the purchaseData parameter to the Transfer.prepare call, addressing the bug where purchase metadata wasn't being included in PayEmbed transfers. The fix is minimal, safe, and maintains backward compatibility since purchaseData is optional.

.changeset/upset-views-show.md (1)

1-6: LGTM! Proper changeset documentation.

The changeset correctly categorizes this as a patch release (appropriate for bug fixes) and provides a clear description of the fix.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-05-29T16:57:24Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	61.79 KB (+0.14% 🔺)	1.3 s (+0.14% 🔺)	259 ms (+241.24% 🔺)	1.5 s
thirdweb (cjs)	344.76 KB (+0.07% 🔺)	6.9 s (+0.07% 🔺)	685 ms (+9.25% 🔺)	7.6 s
thirdweb (minimal + tree-shaking)	5.69 KB (0%)	114 ms (0%)	106 ms (+1504.15% 🔺)	220 ms
thirdweb/chains (tree-shaking)	531 B (0%)	11 ms (0%)	16 ms (+804.19% 🔺)	27 ms
thirdweb/react (minimal + tree-shaking)	19.54 KB (0%)	391 ms (0%)	147 ms (+1064.02% 🔺)	538 ms

fix: transfer purchase data

a5942f0

gregfromstl requested review from a team as code owners May 29, 2025 16:51

github-actions bot assigned gregfromstl May 29, 2025

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels May 29, 2025

vercel bot deployed to Preview – wallet-ui May 29, 2025 16:53 View deployment

vercel bot deployed to Preview – login May 29, 2025 16:54 View deployment

vercel bot deployed to Preview – thirdweb_playground May 29, 2025 16:54 View deployment

0xFirekeeper approved these changes May 29, 2025

View reviewed changes

vercel bot deployed to Preview – thirdweb-www May 29, 2025 16:59 View deployment

vercel bot deployed to Preview – docs-v2 May 29, 2025 17:00 View deployment

jnsdls approved these changes May 29, 2025

View reviewed changes

gregfromstl merged commit 3d3c6f3 into main May 29, 2025
21 of 22 checks passed

gregfromstl deleted the greg/fix-transfer-purchase-data branch May 29, 2025 17:30

joaquim-verges mentioned this pull request May 29, 2025

Version Packages #7164

Merged

This was referenced May 30, 2025

[Dashboard] Fix: Purchase Data #7225

Merged

Fix: Universal Bridge Analytics Parsing and Team Analytics Loading State #7288

Closed

coderabbitai bot mentioned this pull request Jul 2, 2025

Pass purchaseData prop to payment components #7507

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: Transfer purchase data #7202

Fix: Transfer purchase data #7202

Uh oh!

gregfromstl commented May 29, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented May 29, 2025

Uh oh!

vercel bot commented May 29, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented May 29, 2025

Uh oh!

coderabbitai bot commented May 29, 2025 •

edited

Loading

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented May 29, 2025

Uh oh!

Uh oh!

Uh oh!

Fix: Transfer purchase data #7202

Fix: Transfer purchase data #7202

Uh oh!

Conversation

gregfromstl commented May 29, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented May 29, 2025

🦋 Changeset detected

Uh oh!

vercel bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented May 29, 2025

How to use the Graphite Merge Queue

Uh oh!

coderabbitai bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented May 29, 2025

size-limit report 📦

Uh oh!

Uh oh!

Uh oh!

gregfromstl commented May 29, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented May 29, 2025 •

edited

Loading

coderabbitai bot commented May 29, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)